On Wed, 3 Jun 2026 12:05:05 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8209814: Fix manifest capabilities and ProblemList alignment per review
>
> test/jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh line 77:
>
>> 75: esac
>> 76:
>> 77: "$JAVA" ${TESTVMOPTS} ${TESTJAVAOPTS} -classpath "${TESTCLASSES}" Setup
>> "${TESTCLASSES}" Agent "${CYGWIN}"
>
> Nit: Just to notice that the `${CYGWIN}` parameter to the agent is not
> supported by the `BootClassPathDriver.java`. In fact, I'm not sure if it is
> important or not. At least, it would be nice to understand better if we still
> need it for some Windows-like environments.
I think we no longer needed.. tests pass on windows-x64 without it. the old
shell scripts used it for path conversion but the java conversions handle paths
natively.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31288#discussion_r3357888952
