On Tue, 9 Jun 2026 11:48:29 GMT, Kevin Walls <[email protected]> wrote:
>> src/hotspot/os/linux/os_linux.cpp line 1565:
>>
>>> 1563: AltTempDir = nullptr;
>>> 1564: } else if (!is_writeable_directory(AltTempDir)) {
>>> 1565: log_warning(os)("Error: AltTempDir is ignored because it is not
>>> present or writable");
>>
>> Suggestion:
>>
>> log_warning(os)("Error: AltTempDir is ignored because it is not an
>> existing writeable directory");
>
> I thought of changing the function to is_writable_directory() as we have far
> more "writable" than "writeable" overall. 8-)
>
> src/hotspot/share/runtime/arguments.cpp is maybe the best sample of both
> variants.
>
> One online source says, "...writeable is an accepted alternate (often used in
> computing), dropping the "e" is the correct grammatical rule...". But we are
> not consistent.
Note I was not intending to comment on the writeable/writable controversy -
pick whichever seems appropriate.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3384980378
