On Fri, 3 Jul 2026 12:59:49 GMT, Kieran Farrell <[email protected]> wrote:
>> Yes that is unfortunate. >> >> We need to know that the jcmd cannot possibly cause an exit, so the >> verification in the diagnostic framework side has to be complete. 8-) >> >> LauncherHelper's showSettings calls validateOption(), and looks like the >> only caller, so maybe it's not too bad to make validateOption() throw and >> never abort/exit, and have showSettings itself conditionally abort/exit >> based on that. Then the jcmd or showSettingsBytes can call validateOption >> and check for an exception. >> >> If that works out too ugly then yes whatever you can do to group the lists >> together will help them stay in sync. > > that works, I've pushed the update now OK great thanks. Looks like we will say things twice in the "jcmd ... help VM.show_settings" output. Could we just say: "Print information similar to 'java -XshowSettings'. See 'java -X' for supported sections." (I would find it helpful to spell out that `java -XshowSettings` has the list, i.e. to hint you are looking at the launcher, not jcmd.) Then could the "section" description above just then be "Optional section." without the need to refer again to where to find the full list. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r3534992179
