On Fri, 3 Jul 2026 10:08:08 GMT, Severin Gehwolf <[email protected]> wrote:
>> Kieran Farrell has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> extend test coverage and code clean up
>
> src/hotspot/share/services/diagnosticCommand.cpp line 487:
>
>> 485: strcmp(sec, "security:providers") != 0 &&
>> 486: strcmp(sec, "security:tls") != 0 &&
>> 487: strcmp(sec, "system") != 0) {
>
> Drive by comment:
>
> `-XshowSettings:system` is Linux only. Should this be accounted for here? On
> non-Linux it falls back to "all".
Feel free to disregard. Though, output for it won't be very insightful for any
non-linux platform.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r3519605396
