On Wed, 15 Jul 2026 02:54:11 GMT, Benjamin Peterson <[email protected]> wrote:
>> David Simms has updated the pull request incrementally with 11 additional >> commits since the last revision: >> >> - Merge branch '8317277' into jep401_sub_review_8317278 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8387703: [lworld] address batch of comments in mainline PR >> >> Co-authored-by: Tobias Hartmann <[email protected]> >> Reviewed-by: thartmann, dlong >> - 8387661: [lworld] move generate_return_value_stub() to SharedRuntime >> >> Reviewed-by: adinn, thartmann >> - 8387405: [lworld] is_always_flat_in_array should be always false >> >> Reviewed-by: thartmann >> - 8387686: [lworld] Update the JNI specification version for value types >> >> Reviewed-by: alanb, dsimms >> - 8387726: [lworld] JVMTI/JDWP/JDI docs cleanup >> >> Reviewed-by: sspitsyn, cjplummer >> - 8387673: [lworld] C2: clone() intrinsic does not throw >> CloneNotSupportedException for value classes not implementing Cloneable >> >> Reviewed-by: thartmann >> - 8387709: [lworld] Split Valhalla tests from tier1_compiler_3 to avoid >> task timeouts >> >> Reviewed-by: chagedorn >> - 8387350: [lworld] ObjectOutputStream.writeObject() doesn't throw >> InvalidClassException for Serializable instance with strict init fields >> >> Reviewed-by: alanb, jpai, thartmann >> - ... and 1 more: https://git.openjdk.org/jdk/compare/f1f6d35d...1b6f7c18 > > src/hotspot/share/code/vtableStubs.hpp line 74: > >> 72: // VtableStubs creates the code stubs for compiled calls through vtables. >> 73: // There is one stub per (vtable index, args_size) pair, and the stubs >> are >> 74: // never deallocated. They don't need to be GCed because they contain no >> oops. > > This description is already out of date in the mainline, but the addition of > the `caller_is_c1` dimension makes it even more wrong. I have > https://github.com/openjdk/jdk/pull/31718 to update the comments relative to > mainline, but Valhalla may need to make some tweaks too. Would it make sense to wait for mainline integration of Valhalla and then update the comment with https://github.com/openjdk/jdk/pull/31718 to also include Valhalla specifics? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3585246602
