On Wed, 15 Jul 2026 07:19:35 GMT, Tobias Hartmann <[email protected]> wrote:
>> src/hotspot/share/code/vtableStubs.hpp line 74: >> >>> 72: // VtableStubs creates the code stubs for compiled calls through >>> vtables. >>> 73: // There is one stub per (vtable index, args_size) pair, and the stubs >>> are >>> 74: // never deallocated. They don't need to be GCed because they contain >>> no oops. >> >> This description is already out of date in the mainline, but the addition of >> the `caller_is_c1` dimension makes it even more wrong. I have >> https://github.com/openjdk/jdk/pull/31718 to update the comments relative to >> mainline, but Valhalla may need to make some tweaks too. > > Would it make sense to wait for mainline integration of Valhalla and then > update the comment with https://github.com/openjdk/jdk/pull/31718 to also > include Valhalla specifics? I can do that. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3588463596
