On Wed, 15 Jul 2026 16:50:18 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains nine >> additional commits since the last revision: >> >> - extra space >> - Merge branch 'master' into JDK-8386116 >> - Count async exceptions installed/thrown >> - Improve comments >> - Updates in libStopThreadTest2.cpp >> - More comments from David >> - Dan's comments >> - David's comments >> - v1 > > src/hotspot/share/prims/jvmtiEnvBase.hpp line 35: > >> 33: #include "runtime/fieldDescriptor.hpp" >> 34: #include "runtime/frame.hpp" >> 35: #include "runtime/handles.inline.hpp" > > Do we need this include for the new Handle field on L539 below > or can we get away with a forward decl on L46 below? This violates the rules - you don't include an inline.hpp into a plain .hpp ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3593261439
