On Thu, 16 Jul 2026 22:22:38 GMT, David Holmes <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - add testStopAtEmptyTask test
>> - move check to downcallLinker
>> - define constructor in cpp file
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest2/StopThreadTest2.java
> line 32:
>
>> 30: * @requires test.thread.factory == null
>> 31: * @library /test/lib /test/hotspot/jtreg
>> 32: * @run junit/othervm/native -agentlib:StopThreadTest2 StopThreadTest2
>
> Why the switch to junit? This makes tests very difficult to run outside of
> jtreg.
We’ve been using it for tests in `jdk/java/lang/Thread/virtual` when there are
multiple independent test cases, since it provides a clean way to structure the
testing. Since this one only has two cases, we don’t really need it, so I
changed it back to use `main/other`.
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest2/StopThreadTest2.java
> line 93:
>
>> 91: */
>> 92: @Test
>> 93: void testStopAtEmptyTask() throws Exception {
>
> So success of this sub-test is no hangs or crashes?
Exactly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3599463660
PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3599463755
