On Sat, 8 Aug 2026 13:08:14 GMT, David Holmes <[email protected]> wrote:
>> Yunbo Zhang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8390024: Improve ParseCommandLineMemoryTest portability > > src/hotspot/share/prims/wbtestmethods/parserTests.cpp line 160: > >> 158: ResourceMark rm; >> 159: DCmdParser parser; >> 160: DCmdParserMark parser_mark(&parser); > > Shouldn't the `DcmdParser` destructor take care of calling > `DCmdParser::cleanup().`? Thank you, good point. Fixed in be961987a19 by adding cleanup to the DCmdParser destructor. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32263#discussion_r3742936585
