On Sat, 8 Aug 2026 16:55:28 GMT, Yunbo Zhang <[email protected]> wrote:

>> 8390024: WB_ParseCommandLine leaks C-heap memory when parsing STRING 
>> arguments
>> 
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Yunbo Zhang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8390024: Clean up DCmdParser on destruction

This seems a better approach to me, but does raise the question about why this 
was not done before. It also isn't clear that `cleanup()` is idempotent, so if 
it is already called directly in places then this change may break things. This 
needs more general investigation and testing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/32263#pullrequestreview-4891346949

Reply via email to