On Wed, 19 Aug 2026 23:17:30 GMT, Dean Long <[email protected]> wrote:

>> This PR removes the last traces of the obsolete thread transition states 
>> such as _thread_new_trans, _thread_blocked_trans, etc.  These states have 
>> not been needed ever since the JVM switched safepoints from doing forced 
>> suspend to cooperative self-suspend.  Most were no longer used thanks to 
>> previous work by @pchilano , but there remained uses of 
>> _thread_in_native_trans that are now safely converted into _thread_in_vm.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Dean Long has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix reference to native_trans

Typo needs fixing.

src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 1499:

> 1497:   // Now before we return to java we must look for a current safepoint
> 1498:   // (a new safepoint can not start since we entered _thread_in_vm).
> 1499:   // We must check here because a current safepoint could in progress.

Suggestion:

  // We must check here because a current safepoint could be in progress.

src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp line 1585:

> 1583:   // Now before we return to java we must look for a current safepoint
> 1584:   // (a new safepoint can not start since we entered _thread_in_vm).
> 1585:   // We must check here because a current safepoint could in progress.

Suggestion:

  // We must check here because a current safepoint could be in progress.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32415#pullrequestreview-4978506845
PR Review Comment: https://git.openjdk.org/jdk/pull/32415#discussion_r3818157003
PR Review Comment: https://git.openjdk.org/jdk/pull/32415#discussion_r3818157669

Reply via email to