On Thu, 20 Aug 2026 03:05:14 GMT, Dean Long <[email protected]> wrote:

>> This PR removes the last traces of the obsolete thread transition states 
>> such as _thread_new_trans, _thread_blocked_trans, etc.  These states have 
>> not been needed ever since the JVM switched safepoints from doing forced 
>> suspend to cooperative self-suspend.  Most were no longer used thanks to 
>> previous work by @pchilano , but there remained uses of 
>> _thread_in_native_trans that are now safely converted into _thread_in_vm.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Dean Long has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Update src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp
>    
>    Co-authored-by: David Holmes 
> <[email protected]>
>  - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>    
>    Co-authored-by: David Holmes 
> <[email protected]>

Only found one minor thing in s390. Apart from that it looks good. Thanks Dean!

src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp line 1603:

> 1601:   // Back in Interpreter Frame.
> 1602: 
> 1603:   // We are in _thread_in_native_vm here and back in the normal

Suggestion:

  // We are in _thread_in_vm here and back in the normal

-------------

Marked as reviewed by fbredberg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32415#pullrequestreview-4982990929
PR Review Comment: https://git.openjdk.org/jdk/pull/32415#discussion_r3821789744

Reply via email to