On Fri, 21 Aug 2026 17:05:28 GMT, Chris Plummer <[email protected]> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Refactoring
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Inline.java line 53:
> 
>> 51:         super(handle, heap);
>> 52:         this.klass = klass;
>> 53:         isFlattened = klass != null; // Assumes this instance is 
>> flattened if klass is passed.
> 
> Is klass ever nulll? Seems that it is something that we should assert here, 
> and just always set isFlattened to true.

For consistency, `Inline(OopHandle handle, ObjectHeap heap)` calls this c'tor 
like `this(handle, heap, null)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32310#discussion_r3834922981

Reply via email to