On Fri, 21 Aug 2026 19:36:45 GMT, Coleen Phillimore <[email protected]> wrote:
>> This PR is a follow-up to >> [JDK-8389325](https://bugs.openjdk.org/browse/JDK-8389325) ("Remove the >> UseObjectMonitorTable flag and related code"). It: >> - Removes obsolete mark-word and monitor-pointer support. >> - Removes displaced-mark related code in garbage collectors (G1, Parallel GC >> and Shenandoah). >> - Renames UseObjectMonitorTableTest to ObjectMonitorTableTest. >> - Addresses all the leftover review comments from >> [JDK-8389325](https://bugs.openjdk.org/browse/JDK-8389325). >> >> Passes tier1-5 tests successfully on supported platforms. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/hotspot/share/runtime/objectMonitor.hpp line 236: > >> 234: uintptr_t metadata() const; >> 235: void set_metadata(uintptr_t value); >> 236: volatile uintptr_t* metadata_addr(); > > If I remember this correctly metadata could be two different things, but with > the lock in the markWord gone, it can now only be one thing. But I guess > that one thing is the hash code as uintptr_t ? > Is metadata_addr() used? I agree we should probably fold `metadata` into `hash` functions and rename and retype the field to be `intptr_t _hash` a bit more churn but feels like we do not benefit from this abstraction anymore. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32471#discussion_r3841312593
