On Mon, 24 Aug 2026 19:01:46 GMT, Coleen Phillimore <[email protected]> wrote:

>> I think this whole method could use some cleanup. This just prints the value 
>> of the markWord (same as before) but it did so because it did not want to go 
>> chasing displaced marked words. Similarly the `is_locked` leg did not want 
>> to go chase stack locks.
>> 
>> Neither exists anymore. It is really only the GC that displaces/preservers 
>> the markWord in a STW collection because of forwarding pointers. So we 
>> should clean this up to be if marked just print the value, else actually 
>> print some more state.
>> 
>> Similarly we should clean up the valhalla invariants now that we do not 
>> displace markWords.
>
> I think this else clause should be removed from printing first though, with 
> this change.

Rewrote `markWord::print_on()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32471#discussion_r3847556245

Reply via email to