On Thu, 27 Aug 2026 09:01:46 GMT, Stefan Karlsson <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update markWord comments > > src/hotspot/share/cds/aotMappedHeapWriter.cpp line 732: > >> 730: address buffered_addr = >> requested_addr_to_buffered_addr(cast_from_oop<address>(requested_obj)); >> 731: >> 732: markWord mw = Arguments::enable_preview() ? >> src_klass->prototype_header() : markWord::prototype(); > > Suggestion: > > markWord mw = Arguments::is_valhalla_enabled() ? > src_klass->prototype_header() : markWord::prototype(); > > like what the old code used. Or is there a reason why `enable_preview` is > more correct here? It should not, I'll update it to `valhalla`, I based it on the streaming code, which uses preview. But both should use `is_valhalla_enabled`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32535#discussion_r3870288442
