On Thu, 27 Aug 2026 08:31:07 GMT, Johan Sjölen <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply suggestion from @stefank >> >> Co-authored-by: Stefan Karlsson <[email protected]> > > src/hotspot/share/oops/markWord.hpp line 76: > >> 74: // * valhalla reserved: Reserved for future use >> 75: // >> 76: // Inline types cannot be locked and have a deterministic identity >> hash based > > You should split this into two sentences to make the meaning clearer. > > > // Inline types cannot be locked. > // They have a deterministic hash based on the immutable payload and class, > which may be cached in the markWord. > > > Otherwise, it sounds like when they are locked their hash is > non-deterministic. It's weird to call it an identity hash as well, so I removed the word "identity" from the comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32535#discussion_r3870038593
