On Thu, 10 Sep 2026 12:45:58 GMT, Thomas Schatzl <[email protected]> wrote:
>> Yunbo Zhang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8311029: Print minimum G1HeapRegionSize in constraint error > > src/hotspot/share/gc/g1/jvmFlagConstraintsG1.cpp line 88: > >> 86: "G1HeapRegionSize (%zu) must be " >> 87: "greater than or equal to ergonomic heap region >> minimum size (%zu)\n", >> 88: value, G1HeapRegionBounds::min_size()); > > Maybe convert this to MB? The minimum is always supposed to be a multiple of > MBs, and the endlessly long in-bytes number is awkward to use. > > > Suggestion: > > "greater than or equal to ergonomic heap region > minimum size (%zuM)\n", > value, G1HeapRegionBounds::min_size() / M); > > > (Did not check if that M value is in scope). Thanks for the review. I fixed the formatting issue and updated the error message to print the minimum region size in MiB. Could you please take another look? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32749#discussion_r3982334262
