On Tue, 8 Sep 2026 03:59:00 GMT, April Ivy <[email protected]> wrote: >> Yunbo Zhang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8311029: Address review comments > > `AfterErgo` is the right phase, it runs right after `apply_ergo()` so > `UseG1GC` is settled, and well before `setup_heap_region_size()` does the > adjusting. Dropping `FLAG_IS_CMDLINE` is safe for the same reason: the only > ergonomic setter sits inside that adjustment. > > I grepped the test tree and MemoryManagement.java was the only sub-1M value, > so you have them all. > > Now that the message is reachable, could it print the minimum too? Someone > who typed 16 meaning 16m is told they are below the minimum without being > told what it is.
@aprilivy Thanks for the earlier review. I have addressed the review comments in commit 8883400084a. Could you please re-review the latest commit and re-approve the PR? ------------- PR Comment: https://git.openjdk.org/jdk/pull/32749#issuecomment-5632722294
