On Thu, 10 Sep 2026 20:11:34 GMT, Coleen Phillimore <[email protected]> wrote:
>> Remove the upcall to addClass during class loading. The comment says it's >> only so GC can keep classes alive while the class loader is alive. We have >> other ways to do that. There were some JVMTI tests in the past that failed >> without this vector but today seems to be only one test. Maybe there's some >> code that has a dependency on this in heap walking. >> Tested tier1-6 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Remove JVMTI_REFERENCE_HEAP_OTHER for old Heap 1.0 call. Exclude hidden > classes from compatible class walk. src/hotspot/share/prims/jvmtiTagMap.cpp line 2473: > 2471: // Reporting classes from the class loader is not supported for old > Heap 1.0 functions. > 2472: if (is_basic_heap_walk()) { > 2473: return false; I think this needs to return true, otherwise it's going to as if a callback returned JVMTI_ITERATION_ABORT. Hopefully there are good tests for this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3988623159
