On Fri, 11 Sep 2026 11:19:46 GMT, Alan Bateman <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove JVMTI_REFERENCE_HEAP_OTHER for old Heap 1.0 call. Exclude hidden
>> classes from compatible class walk.
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 2473:
>
>> 2471: // Reporting classes from the class loader is not supported for old
>> Heap 1.0 functions.
>> 2472: if (is_basic_heap_walk()) {
>> 2473: return false;
>
> I think this needs to return true, otherwise it's going to as if a callback
> returned JVMTI_ITERATION_ABORT. Hopefully there are good tests for this.
This is the old API that's deprecated iirc so if there were tests, they'd be
deleted. There don't seem to be any tests that I can find.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3991353634
