On Thu, 17 Sep 2026 07:01:23 GMT, Andrew Haley <[email protected]> wrote:
>> I'm not opposed to this patch as is, but it's another workaround for a >> broken approach to unwinding. >> DWARF CFI unwinding is the proper way to do it. >> https://blog.mozilla.org/jseward/2014/05/13/lul-a-lightweight-unwinder-library-for-profiling-gecko/ >> is worth investigating. > >> @theRealAph I'm not opposed to fixing this the proper way using DWARF CFI >> unwinding, but that is a much bigger job. Until that is done, this PR fixes >> a possible failing `assert()` when trying to profile using `gprofng`. > > I agree, but we're piling kludges on workarounds, building up technical debt. > I have no objection to this specific patch, but one day we're going to have > to pay back that debt. > @theRealAph ...but we're piling kludges on workarounds, building up technical > debt. I have no objection to this specific patch, but one day we're going to > have to pay back that debt. For sure, let's just hope that this PR doesn't push us past the tipping point. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32850#issuecomment-5711947975
