On Thu, 1 Oct 2026 04:09:57 GMT, David Holmes <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix some code indents > > src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m line 46: > >> 44: #import <sys/signal.h> // kill, SIGCONT >> 45: #import <sys/proc.h> // SIDL, SRUN, SSLEEP, SSTOP, SZOMB >> 46: #import <sys/proc_info.h> // proc_bsdinfo, PROC_PIDTBSDINFO > > We don't usually document why a header is needed. Fixed. > src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m line 50: > >> 48: >> 49: // The SA libproc.h uses the same _LIBPROC_H_ guard as the macOS SDK's >> 50: // libproc.h, so we can't include it. We need to declare proc_pidinfo() > > Sounds like it would be a good idea to rename the SA header file to avoid the > conflict. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33158#discussion_r4152229408 PR Review Comment: https://git.openjdk.org/jdk/pull/33158#discussion_r4152231120
