On Thu, 1 Oct 2026 05:53:45 GMT, Chris Plummer <[email protected]> wrote:

>> On macOS 26.6.2 and 27, all the SA process tests are failing with a timeout. 
>> I manually attached to a java process using clhsdb, and after the detach the 
>> debuggee process was left suspended, so this seems to be the issue causing 
>> the timeouts. Details in first comment.
>> 
>> - Tested with all svc tier1 through tier8 testing on macosx-aarch64-debug.
>> - Ran all SA tests on various mach5 hosts 50 times each on macosx-aarch64 
>> and macosx-aarch64-debug.
>> - Tested on macOS 26.6.2 personal device by running serviceability/sa 120 
>> times on combination of debug and product builds
>> - Tested on macOS 27 mach5 devices by running serviceability/sa 100 times.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   resolve issue with SA's libproc.h conflict with OSX header by the same name

I'm thinking of reworking this fix and going back to the sort delay fix I once 
had in place. At that time it was only a 1ms delay, and took many iterations 
before I saw a failure. I believe the delay was too short, and the reason the 
SIGCONT approach worked better is because it has a 10ms delay. Going with this 
approach will make this review much simpler. It will just involve the moving of 
the exception reply code and one usleep(10000) before the PT_DETACH. The 
task_resume() call and SIGCONT code would be removed, along with all the new 
utility APIs they rely on. I have a lot of testing to do first to prove this 
approach is as robust as the SIGCONT approach.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33158#issuecomment-5940263464

Reply via email to