On Thu, 15 Oct 2026 03:43:54 GMT, Dingli Zhang <[email protected]> wrote:
>> Long Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use the CIE return-address column instead of the hard-coded RA register > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/riscv64/LinuxRISCV64CFrame.java > line 100: > >> 98: } >> 99: } >> 100: } > > Could we honor the CIE return-address column in both the stack lookup and the > register fallback? GCC's `__riscv_save_*` helpers use x5, while > `getReturnAddressOffsetFromCFA()` still queries x1. Depending on where the > thread stops, this can throw or skip the helper's immediate caller. Thanks, pushed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33374#discussion_r4282940522
