On Thu, 15 Oct 2026 03:42:47 GMT, Dingli Zhang <[email protected]> wrote:
>> Long Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> RISC-V: Use compiler-defined macros for DWARF register selection > > src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.hpp line 37: > >> 35: #elif defined(__aarch64__) >> 36: #include "dwarf_regs_aarch64.h" >> 37: #elif defined(riscv64) > > Suggestion: > > #elif defined(__riscv) && __riscv_xlen == 64 > > Minor: maybe we can use `defined(__riscv) && __riscv_xlen == 64`? > `defined(riscv64)` works with the build-provided `-Driscv64`, but the > adjacent x86_64 and aarch64 branches use compiler predefined macros. Using > the corresponding RISC-V macros would keep this consistent. Pushed. Compiler-defined macros are better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33374#discussion_r4293167503
