On Mon, 19 Oct 2026 22:42:29 GMT, Leonid Mesnik <[email protected]> wrote:
>> Please review this small test fix. >> >> `lib.jdb.Jdb` does not pass `test.vm.opts` or `test.java.opts` to the jdb JVM >> >> **Fix:** Use `JDKToolLauncher` to pass both sets of options to jdb >> >> **Testing:** >> >> - [x] Added coverage in `JdbOptions.java` >> - [x] `com/sun/jdi`: 191 passed, 1 excluded >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/com/sun/jdi/lib/jdb/Jdb.java line 45: > >> 43: public Jdb(String... args) { >> 44: JDKToolLauncher launcher = >> JDKToolLauncher.createUsingTestJDK("jdb") >> 45: .addVMArgs(Utils.getTestJavaOpts()) > > The debugger is not tested process.. So jdb doesn't need to be executed with > test.java.opts, only with test.vm.opts. @benshuai5D As I understand, Leonid suggests to remove passing the `test.java.opts` to JDB from you fix. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33424#discussion_r4319679630
