> Please review this small test fix. 
> 
> `lib.jdb.Jdb` does not pass `test.vm.opts` or `test.java.opts` to the jdb JVM
> 
> **Fix:** Use `JDKToolLauncher` to pass both sets of options to jdb
> 
> **Testing:**
> 
> - [x] Added coverage in `JdbOptions.java`
> - [x] `com/sun/jdi`: 191 passed, 1 excluded
> 
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Yunbo Zhang has updated the pull request incrementally with one additional 
commit since the last revision:

  8282988: nsk/jdb and com/sun/jdi tests do not run jdb or debuggee with 
specified JVM args
  
  Forward only test.vm.opts to the jdb VM using Utils.getForwardVmOptions().
  Check that test.java.opts is not forwarded.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33424/files
  - new: https://git.openjdk.org/jdk/pull/33424/files/bc254e34..181a3f01

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33424&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33424&range=00-01

  Stats: 7 lines in 2 files changed: 0 ins; 1 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/33424.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33424/head:pull/33424

PR: https://git.openjdk.org/jdk/pull/33424

Reply via email to