On Tue, 20 Oct 2026 17:06:03 GMT, Yunbo Zhang <[email protected]> wrote:

>> Please review this small test fix. 
>> 
>> `lib.jdb.Jdb` does not pass `test.vm.opts` or `test.java.opts` to the jdb JVM
>> 
>> **Fix:** Forward `test.vm.opts` to jdb using `Utils.getForwardVmOptions()`
>> 
>> **Testing:**
>> 
>> - [x] Added coverage in `JdbOptions.java`
>> - [x] `com/sun/jdi`: 191 passed, 1 excluded
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Yunbo Zhang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8282988: nsk/jdb and com/sun/jdi tests do not run jdb or debuggee with 
> specified JVM args
>   
>   Forward only test.vm.opts to the jdb VM using Utils.getForwardVmOptions().
>   Check that test.java.opts is not forwarded.

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/33424#pullrequestreview-5588855878

Reply via email to