On Thu, 22 Oct 2026 22:04:50 GMT, Chris Plummer <[email protected]> wrote:

> I noticed under src/jdk.hotspot.agent/macosx/native/libsaproc/ we still have 
> a bunch of FreeBSD native code. You'll find it within #ifdef's like the 
> following:
> 
> #ifdef __APPLE__
> // macosx code
> #else
> // FreeBSD code
> #endif
> 
> The #else part is only needed for the FreeBSD port, which is now located 
> under src/jdk.hotspot.agent/bsd/native/libsaproc/ (in the jdk freebsd repo). 
> All of it can be deleted, and I got approval from the bsd team to do this. It 
> is a fairly large chunk of code, and removing it will make browsing the 
> macosx code simpler. No more false grep hits.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33524#pullrequestreview-5623076740

Reply via email to