On Wed, 28 Oct 2026 01:57:20 GMT, Chris Plummer <[email protected]> wrote:
>> I noticed under src/jdk.hotspot.agent/macosx/native/libsaproc/ we still have >> a bunch of FreeBSD native code. You'll find it within #ifdef's like the >> following: >> >> #ifdef __APPLE__ >> // macosx code >> #else >> // FreeBSD code >> #endif >> >> The #else part is only needed for the FreeBSD port, which is now located >> under src/jdk.hotspot.agent/bsd/native/libsaproc/ (in the jdk freebsd repo). >> All of it can be deleted, and I got approval from the bsd team to do this. >> It is a fairly large chunk of code, and removing it will make browsing the >> macosx code simpler. No more false grep hits. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > feedback cleanup Thank you for updates. Re-approved. ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33524#pullrequestreview-5677246328
