On Fri, 30 Oct 2026 02:35:43 GMT, Long Yang <[email protected]> wrote:

>> Long Yang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Move the isSignalTrampoline check to just after stripPAC
>
> Thank you all.

@yanglong1010 @y1yang0 Just a reminder that hotspot changes require two 
reviewers. Also, it is best to make sure an Oracle engineer is involved. I 
usually run changes like this through some Oracle CI testing to make sure there 
are no issue. And lastly, I don't see any mention of test coverage for this. Is 
it possible to add a test case that would fail without these changes? Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33620#issuecomment-6525067302

Reply via email to