On Fri, 30 Oct 2026 14:20:45 GMT, Chris Plummer <[email protected]> wrote:
>> Thank you all. > > @yanglong1010 @y1yang0 Just a reminder that hotspot changes require two > reviewers. Also, it is best to make sure an Oracle engineer is involved. I > usually run changes like this through some Oracle CI testing to make sure > there are no issue. And lastly, I don't see any mention of test coverage for > this. Is it possible to add a test case that would fail without these > changes? Thanks. @plummercj Sorry for the trouble, and thanks for taking the time to point this out, and I apologize for the process issues. I was not aware that hotspot changes require two reviewers with at least one Oracle engineer involved. I will make sure to follow this convention in the future. If it helps, I am happy to have this change re-reviewed, run through Oracle CI, or reverted if needed. Regarding test coverage: I ran the existing tests under test/hotspot/jtreg/serviceability/sa on amd64 and aarch64, but I did not add a new targeted test. I will investigate whether a reproducible test case is feasible and follow up. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33620#issuecomment-6568536239
