On Mon, 2 Nov 2026 15:38:05 GMT, Chris Plummer <[email protected]> wrote:
>> jonghoonpark has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add outputs in test >> >> Signed-off-by: jonghoonpark <[email protected]> > > Overall this looks good but I prefer the more verbose output of the original > reproducer. Can you include some of that output with the test run? > > Also, shouldn't the test assert that it always finds the Location.Type.VECTOR > type (and you might want to note in the test output when it is found). @plummercj Thanks for the review! I’ve updated the test to print more verbose output, similar to the original reproducer. It now prints the ScopeDesc, ObjectValue and ScopeValue being inspected, and notes when a VECTOR location is found. Here’s part of the output from a test run: ### ScopeDesc: ScopeDesc for Method LingeredAppWithVector.test([I)I@0x0000000116401470 @bci 9 reexecute=false ## ObjectValue: scalarObj[45] # ScopeValue: Value 7, stack[0],vector Found a Location of type vector Regarding the assertion: the test already fails if no `Location.Type.VECTOR` is found. The `if (!vectorFound)` check at the end of `checkDecode()` throws in that case, so the test can’t pass silently without encountering a VECTOR location. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33665#issuecomment-6581977224
