On Tue, 3 Nov 2026 14:40:14 GMT, Chris Plummer <[email protected]> wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/Location.java line
>> 124:
>>
>>> 122: /** NarrowOop (please GC me!) */
>>> 123: public static final Type NARROWOOP = new Type("narrowoop");
>>> 124: /** Long held in one register */
>>
>> Looks like a typo, but I left it as is since it’s out of scope for this
>> change.
>
> I forgot to ask last time around what you think is a typo here.
Two different constants have the same comments.
/** Long held in one register */
public static final Type INT_IN_LONG = new Type("int_in_long");
/** Long held in one register */
public static final Type LNG = new Type("lng");
But in `location.hpp` they have different comment.
int_in_long, // Integer held in long register
lng, // Long held in one register
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33665#discussion_r4456457579