On Tue, 3 Nov 2026 08:12:08 GMT, Emanuel Peter <[email protected]> wrote:
>> jonghoonpark has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add outputs in test >> >> Signed-off-by: jonghoonpark <[email protected]> > > test/hotspot/jtreg/serviceability/sa/LingeredAppWithVector.java line 32: > >> 30: public class LingeredAppWithVector extends LingeredApp { >> 31: >> 32: private static final VectorSpecies<Integer> SPECIES = >> IntVector.SPECIES_128; > > I think it would be good to also test this will all other vector types, no? > What happens with floats, for example? @eme64 Thanks for the review! I've updated the test based on your feedback. - Added 10 vector types: all six element types for 128-bit, and Byte/Short/Int/Float for 64-bit. - Excluded `LongVector64` and `DoubleVector64`, which have a single lane: - `LongVector64`: C2 rejects both load and reduction on aarch64 and x86. - `DoubleVector64`: rejected on aarch64. On x86, the load is allowed, but the reduction is still rejected. (x86 was checked under Rosetta) As for floats, both `FloatVector128` and `FloatVector64` decode as `Location::vector`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33665#discussion_r4456022569
