On Thu, 5 Nov 2026 06:13:19 GMT, Jean-Noël Rouvignac <[email protected]> wrote:
>> This PR renames a few C++ APIs that refer to the AOT configuration and AOT >> cache to improve source code consistency: >> >> "preimage" -> "aot configuration" >> "final image" -> "aot cache" >> >> Also, the class `FinalImageRecipes` is renamed to `AOTMetaspaceRecipes`, as >> it contains only "recipes" for optimizing metaspace objects such as >> `InstanceKlass` and `ConstantPool`. (E.g., Recipes for compiler >> optimizations are stored in `trainingData.hpp`.). >> >> The main changes are in >> >> - aotMetaspace.hpp >> - aotMetaspaceRecipes.hpp >> - cdsConfig.hpp >> - filemap.hpp >> - filemap.cpp >> >> The changes in other files are simply renaming of function names, as well as >> comment updates. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/hotspot/share/cds/aotConstantPoolResolver.cpp line 531: > >> 529: Klass* k = find_loaded_class(Thread::current(), >> cp->pool_holder()->class_loader(), klass_name); >> 530: if (k == nullptr) { >> 531: // Dumping AOT cache: all classes should have been loaded by >> AOTMetsapceRecipes::load_all_classes(). k must have > > Typo here and next line: AOTMetsapceRecipes > > vs. > > AOTMetaspaceRecipes Actually these typos are everywhere in this PR ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33734#discussion_r4477228542
