On Fri, 6 Nov 2026 19:00:29 GMT, Ioi Lam <[email protected]> wrote:

>> This PR renames a few C++ APIs that refer to the AOT configuration and AOT 
>> cache to improve source code consistency:
>> 
>> "preimage" -> "aot configuration"
>> "final image" -> "aot cache"
>> 
>> Also, the class `FinalImageRecipes` is renamed to `AOTMetaspaceRecipes`, as 
>> it contains only "recipes" for optimizing metaspace objects such as 
>> `InstanceKlass` and `ConstantPool`. (E.g., Recipes for compiler 
>> optimizations are stored in `trainingData.hpp`.).
>> 
>> The main changes are in
>> 
>> - aotMetaspace.hpp
>> - aotMetaspaceRecipes.hpp
>> - cdsConfig.hpp
>> - filemap.hpp
>> - filemap.cpp
>> 
>> The changes in other files are simply renaming of function names, as well as 
>> comment updates.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ioi Lam has updated the pull request with a new target base due to a merge or 
> a rebase. The pull request now contains eight commits:
> 
>  - Fixed merge
>  - more comment fixes
>  - Merge branch 'master' into 
> 8366473-clean-up-cpp-apis-for-aot-config-and-aot-cache
>  - @JnRouvignac comment: fixed typo
>  - step4
>  - step3
>  - step2
>  - step1

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33734#pullrequestreview-5807329386

Reply via email to