On Tue, 10 Nov 2026 15:52:17 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> test/hotspot/jtreg/serviceability/sa/TestELFDebuginfo.java line 69:
>
>> 67: // it is not an exported function. In addition
>> .note.gnu.build-id ELF
>> 68: // section is removed, so SA should find out associated
>> debuginfo from
>> 69: // .gnu_debuglink section.
>
> Suggestion:
>
> // callSleep() JNI function calls sleep_internal(). Both functions
> // are provided by libDebuginfoTest.so, which is stripped with
> --strip-all
> // in build process. See BUILD_TEST_libDebuginfoTest in
> make/test/JtregNativeHotspot.gmk.
> // It does not have the sleep_internal() symbol because
> // it is not an exported function. In addition the .note.gnu.build-id
> ELF
> // section is removed, forcing SA to find out the associated
> debuginfo from
> // the .gnu_debuglink section instead.
>
>
> I think maybe you can also remove the comment about sleep_internal(). I don't
> see why not exporting it is important to how the test works, but maybe I'm
> not understanding something.
`sleep_internal()` is an important point of this test because it would be
stripped - SA have to read debuginfo to find out it (hence I checked it with
`out.shouldContain("sleep_internal")`). Otherwise we would see `?????` as a
callee of `callSleep()` in the output of mixed jstack because SA cannot find
the symbol.
BTW your suggestion is to replace L64-L69?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33764#discussion_r4532184073
