On Tue, 10 Nov 2026 15:52:17 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix > > test/hotspot/jtreg/serviceability/sa/TestELFDebuginfo.java line 69: > >> 67: // it is not an exported function. In addition >> .note.gnu.build-id ELF >> 68: // section is removed, so SA should find out associated >> debuginfo from >> 69: // .gnu_debuglink section. > > Suggestion: > > // callSleep() JNI function calls sleep_internal(). Both functions > // are provided by libDebuginfoTest.so, which is stripped with > --strip-all > // in build process. See BUILD_TEST_libDebuginfoTest in > make/test/JtregNativeHotspot.gmk. > // It does not have the sleep_internal() symbol because > // it is not an exported function. In addition the .note.gnu.build-id > ELF > // section is removed, forcing SA to find out the associated > debuginfo from > // the .gnu_debuglink section instead. > > > I think maybe you can also remove the comment about sleep_internal(). I don't > see why not exporting it is important to how the test works, but maybe I'm > not understanding something. @plummercj I updated comments with your suggestion. Could you review again? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33764#discussion_r4593522439
