On Mon, Jan 28, 2019 at 4:21 AM Sam Hague <[email protected]> wrote: > > > On Wed, Jan 23, 2019, 5:58 AM Dimple Jain <[email protected] wrote: > >> Hi Sam, >> >> I have raised a patch to disable BFD by default and Karthika has modified >> genius csit accordingly. >> >> Here are the patches for the same. Both the patches should be merged >> together. >> >> Can you please review and merge. >> > The genius patch is merged. Does it matter if the CSIT patch is not? > It will need to be merged. Genius CSIT's BFD suite has tests for default behavior which will now change.
> > And do we need anything for netvirt? There is a direct tunnel suite there > also. > Nope. Direct tunnels are a different change, will likely be done during Sodium. > > And what about the plain netvirt CSIT, is that just going to have bfd > disabled? > Yes. Code in netvirt never really used BFD state changes. We also plan to move to OFTunnels soon and BFD is not supported with OFTunnels. > >> >> https://git.opendaylight.org/gerrit/#/c/79629/ >> >> https://git.opendaylight.org/gerrit/#/c/79836/ >> >> >> >> >> >> Thanks & Regards, >> >> Dimple. >> >> >> >> >> >> *From:* [email protected] [mailto: >> [email protected]] *On Behalf Of *Brady Johnson >> *Sent:* Thursday, December 20, 2018 2:34 PM >> *To:* Faseela K <[email protected]> >> *Cc:* odl netvirt dev <[email protected]>; >> [email protected]; [email protected] >> *Subject:* Re: [netvirt-dev] [sfc-dev] Disable BFD monitoring for >> tunnels by default >> >> >> >> No objections from me, thanks. >> >> >> Regards, >> >> >> >> *Brady Johnson* >> >> [email protected] >> >> >> >> [image: Image removed by sender.] >> >> >> >> >> >> >> >> >> >> On Thu, Dec 20, 2018 at 6:31 AM Faseela K <[email protected]> wrote: >> >> Brady/David, >> >> Any objections from sfc side? >> >> Thanks, >> >> Faseela >> >> >> >> *From:* Sam Hague [mailto:[email protected]] >> *Sent:* Wednesday, December 19, 2018 10:30 PM >> *To:* Faseela K <[email protected]> >> *Cc:* [email protected]; [email protected]; >> odl netvirt dev <[email protected]>; Brady Allen >> Johnson <[email protected]> >> *Subject:* Re: [sfc-dev] Disable BFD monitoring for tunnels by default >> >> >> >> >> >> >> >> On Sat, Dec 15, 2018 at 9:42 AM Faseela K <[email protected]> wrote: >> >> Hi, >> >> >> >> There was a discussion in last genius weekly call, whether we can >> disable tunnel monitoring by default. >> >> Vishal indicated that netvirt would prefer disabling monitoring by >> default. >> >> And can be enabled explicitly if required. >> >> Any concerns if we do that? >> >> This is a good idea. We talked about this a while back also and thought >> we decided to do the same. The upstream netvirt csit does not use bfd. >> >> >> >> Does disabling the bfd have any impact on the tunnel issues that are >> being debugged or is this a benign change? >> >> >> >> This would clean up the logs also as the bfd stuff is noisy in the >> ovsdb/vswitchd logs that the upstream csit collects. >> >> >> >> Thanks, >> >> Faseela >> >> _______________________________________________ >> sfc-dev mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/sfc-dev >> >> _______________________________________________ > genius-dev mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/genius-dev >
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
