[
https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594385#action_12594385
]
Kevin Brown commented on SHINDIG-60:
------------------------------------
You've also got some brace alignment issues. Specifically, you should be using
this:
} else {
instead of this:
}
else {
Not mentioned specifically in our style guide, but inherited from the sun style
guide at http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449
> Shindig does not properly support the FEED content type as defined by the
> gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java),
> Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch,
> ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json
> in the same way that the JSON contentType does. It should instead return a
> structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
