[
https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594383#action_12594383
]
Gary Helmling commented on SHINDIG-60:
--------------------------------------
Kevin, I just posted an updated patch to clean up the style issues, please let
me know if you see any other problems.
Dan, the updated patch does away with the "ErrorMsg" property in favor on
consistency with the other usage of makeRequest. It looks like it would be
possible to special case the _IG_FetchFeedAsJson handling in core/legacy.js,
and since it's for backwards compatibility with existing Gadgets, I agree that
might be the best place to handle it. I'm no javascript whiz, but I'll take a
crack at it and post it separately.
If I left out any other handling from your patch, please let me know.
Gary
> Shindig does not properly support the FEED content type as defined by the
> gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java),
> Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch, io.js.patch,
> ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json
> in the same way that the JSON contentType does. It should instead return a
> structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
