[
https://issues.apache.org/jira/browse/SHINDIG-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598212#action_12598212
]
Kevin Brown commented on SHINDIG-60:
------------------------------------
Sorry for the late feedback. There are a couple of minor outstanding issues:
- Comments for parseFeedAsJson should just reference the gadget spec. The
igoogle gadget docs are not canonical, and the opensocial spec may differ. The
ig docs will be eliminated at some point in the future (once igoogle has fully
migrated to the new code)
- Lots of magic numbers in parseFeedasJson. These should be configurable, or at
least constants.
- The feed handling stuff itself should probably be extracted to a separate
class to avoid cluttering ProxyHandler too much.
> Shindig does not properly support the FEED content type as defined by the
> gadgets spec for gadgets.io.MakeRequest
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-60
> URL: https://issues.apache.org/jira/browse/SHINDIG-60
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java),
> Gadget Rendering Server (PHP)
> Reporter: Cassie Doll
> Priority: Critical
> Attachments: fix-SHINDIG-60-bug_rome.patch,
> fix-SHINDIG-60-bug_rome2.patch, fix-SHINDIG-60-bug_rome3.patch,
> fix-SHINDIG-60_legacy.patch, io.js.patch, ProxyHandler.java.patch
>
>
> The FEED contentType in gadgets.io.MakeRequest should not return general json
> in the same way that the JSON contentType does. It should instead return a
> structured object that looks like this:
> http://code.google.com/apis/gadgets/docs/remote-content.html#Fetch_JSON
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
