[ 
https://issues.apache.org/jira/browse/SHINDIG-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631515#action_12631515
 ] 

Robert Bissett commented on SHINDIG-574:
----------------------------------------

I see that jsonperson has been changed to include this function:

    JsonPerson.prototype.getDisplayName = function() {
        return this.getField("displayName");
    }

but person, from which this object inherits, still implements getDisplayName 
with logic to create a name if the 'displayName' field is undefined (which is 
the case currently in Project SocialSite). So there is a conflict between the 
two files and the comments in person.js are now misleading that that the method 
is "guaranteed to return a useful string."

Can person.js be updated so that there is no conflict?


> The restful/rpc apis should be producing a displayName field on the person 
> object. 
> -----------------------------------------------------------------------------------
>
>                 Key: SHINDIG-574
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-574
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (Java)
>            Reporter: Cassie Doll
>            Assignee: Cassie Doll
>            Priority: Blocker
>
> This should be a pretty easy change. 
> - a String displayName field needs to be added to Person
> - the JsonDbContainer should fill it out
> - the javascript person.js should be changed to not implement getDisplayName
> - jsonperson.js should be changed to retrieve the displayName from the json 
> from the server that it is constructed with

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to