[
https://issues.apache.org/jira/browse/SHINDIG-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633839#action_12633839
]
Cassie Doll commented on SHINDIG-574:
-------------------------------------
So, you are right, the user shouldn't have to care what person object is
backing their js calls. However, the key point here is that the server -must-
be returning a displayName from the restful/rpc calls in order for the js to
guarantee a display name value. If the server always returned a value then
jsonperson would be a perfectly fine impl of person.
Perhaps we should just make displayName a required field in the java restful
code somehow?
It is in the main constructor but we don't have any sort of checks for required
fields right now. We could put a simple check in the PersonHandler if we felt
that was a good idea.
What do you think?
> The restful/rpc apis should be producing a displayName field on the person
> object.
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-574
> URL: https://issues.apache.org/jira/browse/SHINDIG-574
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Priority: Blocker
>
> This should be a pretty easy change.
> - a String displayName field needs to be added to Person
> - the JsonDbContainer should fill it out
> - the javascript person.js should be changed to not implement getDisplayName
> - jsonperson.js should be changed to retrieve the displayName from the json
> from the server that it is constructed with
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
