[
https://issues.apache.org/jira/browse/SHINDIG-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631979#action_12631979
]
Cassie Doll commented on SHINDIG-574:
-------------------------------------
I'm not sure I understand.
person.js is still appropriate for containers which aren't backed by the
restful apis yet - which is why jsonperson overrides the method.
When opensocial 0.9 gets discussed on the spec list hopefully the fields on the
javascript side will change to match the restful apis. At that time the
"displayName" field will be part of the opensocial js spec and the jsonperson
implementation can be pulled up to replace the person.js code.
Until then, person.js does not know that such a displayName field exists
(because it isn't in the spec) and so shouldn't reference it.
Also, the comment on person.js still stand because that comment comes from the
js spec, which hasn't changed. So, all restful/rpc container implementors must
guarantee that the displayName person field is populated to remain compliant.
That doesn't affect the js code though.
I'm not sure if I explained that well :)
Please let me know if you understand what I'm trying to get at.
Thanks!
> The restful/rpc apis should be producing a displayName field on the person
> object.
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-574
> URL: https://issues.apache.org/jira/browse/SHINDIG-574
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Priority: Blocker
>
> This should be a pretty easy change.
> - a String displayName field needs to be added to Person
> - the JsonDbContainer should fill it out
> - the javascript person.js should be changed to not implement getDisplayName
> - jsonperson.js should be changed to retrieve the displayName from the json
> from the server that it is constructed with
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
