[
https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: complete-valija-patch.txt
This fixes the remaining issue with caja being injected entirely into head and
re-enables caja for gadgets.
* Thanks to Ihab with whom I worked on this patch. We've separated out the
assembly of the final gadget in RenderingContentRewriter into more buckets than
just head and body because it was already becoming rather messy, dependent on
the order of method calls and difficult to follow. Now the order is decided
completely by assemble(). I think this makes it easier to re-order the
constructed gadget if some re-ordering is desired in the future.
* Changed allowRead and allowCall to grantRead and grantCall as per the new
caja api
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called
> by opensocial-current/feature.xml. The
> RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds
> javascript from feature.xml to the container <head> rather than the <body> as
> before. As a result, when enableCaja is run, attachDocumentStub fails
> because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to
> CajaContentRewriter and to create the appropriate named <div> there directly
> in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
