[
https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jasvir Nagra updated SHINDIG-654:
---------------------------------
Attachment: valija-upgrade-patch4.txt
* Added the enableCaja to CajaContentRewriter as suggested by entu
* Moved the container setup required by caja to caja.js (setup valijaMaker and
give permission to the gadget to use console to log errors)
* Added simple tests to ensure caja is operating (adding more substantial tests
in another patch)
* Added SocialCajaWorld.xml to examples
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt,
> valija-upgrade-patch2.txt, valija-upgrade-patch3.txt,
> valija-upgrade-patch4.txt
>
>
> The enableCaja function is currently implemented in container.js and called
> by opensocial-current/feature.xml. The
> RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds
> javascript from feature.xml to the container <head> rather than the <body> as
> before. As a result, when enableCaja is run, attachDocumentStub fails
> because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to
> CajaContentRewriter and to create the appropriate named <div> there directly
> in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
