[
https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649224#action_12649224
]
Brian Eaton commented on SHINDIG-654:
-------------------------------------
EndToEndTest.java: why change this to add a test case that is commented out?
RenderingContentRewiter.java: please add comments explaining the semantics of
each Part value.
RenderingContentRewriterTest.java: please add tests for the semantics of each
part value.
RenderingContentRewriter.java: this patch does not apply cleanly to shindig
HEAD:
patching file
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
patching file java/server/src/test/resources/endtoend/cajaTest.xml
patching file
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingContentRewriterTest.java
Hunk #1 FAILED at 316.
1 out of 1 hunk FAILED -- saving rejects to file
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingContentRewriterTest.java.rej
patching file
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingContentRewriter.java
Hunk #1 succeeded at 59 with fuzz 1 (offset 6 lines).
Hunk #2 succeeded at 95 (offset -2 lines).
Hunk #3 FAILED at 138.
Hunk #4 FAILED at 162.
Hunk #5 FAILED at 186.
Hunk #6 succeeded at 236 (offset 37 lines).
Hunk #7 FAILED at 243.
Hunk #8 FAILED at 407.
Hunk #9 FAILED at 424.
Hunk #10 FAILED at 450.
Hunk #11 FAILED at 464.
Hunk #12 FAILED at 483.
Hunk #13 FAILED at 511.
10 out of 13 hunks FAILED -- saving rejects to file
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingContentRewriter.java.rej
patching file
java/gadgets/src/main/java/org/apache/shindig/gadgets/JsFeatureLoader.java
patching file
java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
patching file features/opensocial-reference/container.js
patching file features/caja/feature.xml
patching file features/opensocial-current/feature.xml
> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
> Key: SHINDIG-654
> URL: https://issues.apache.org/jira/browse/SHINDIG-654
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Kevin Brown
> Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt,
> valija-upgrade-patch2.txt
>
>
> The enableCaja function is currently implemented in container.js and called
> by opensocial-current/feature.xml. The
> RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds
> javascript from feature.xml to the container <head> rather than the <body> as
> before. As a result, when enableCaja is run, attachDocumentStub fails
> because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to
> CajaContentRewriter and to create the appropriate named <div> there directly
> in html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
